From f21600ecddbfee2ec8528ab25e06bcd7c96283eb Mon Sep 17 00:00:00 2001
From: Lemon <15040771@qq.com>
Date: Wed, 23 Sep 2020 20:31:15 +0800
Subject: [PATCH] =?UTF-8?q?=E6=9B=B4=E6=96=B0=E5=95=86=E5=93=81?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/Controller/v3/GoodsController.php         |  3 +-
 app/Controller/v3/OrderOnlineController.php   |  1 +
 app/Request/v3/GoodsEditorRequest.php         | 36 +++++++++++++++++++
 .../v3/Implementations/GoodsService.php       |  9 ++---
 4 files changed, 42 insertions(+), 7 deletions(-)
 create mode 100644 app/Request/v3/GoodsEditorRequest.php

diff --git a/app/Controller/v3/GoodsController.php b/app/Controller/v3/GoodsController.php
index 2d46258..2fb56f2 100644
--- a/app/Controller/v3/GoodsController.php
+++ b/app/Controller/v3/GoodsController.php
@@ -3,6 +3,7 @@
 namespace App\Controller\v3;
 
 use App\Controller\BaseController;
+use App\Request\v3\GoodsEditorRequest;
 use App\Service\v3\Interfaces\ShopCartServiceInterface;
 use App\Service\v3\Implementations\GoodsActivityService;
 use App\Service\v3\Interfaces\CollectStoreServiceInterface;
@@ -78,7 +79,7 @@ class GoodsController extends BaseController
         return $this->success($res);
     }
 
-    public function update()
+    public function update(GoodsEditorRequest $request)
     {
         $res = $this->goodsService->update($this->request->all());
         return $this->success($res);
diff --git a/app/Controller/v3/OrderOnlineController.php b/app/Controller/v3/OrderOnlineController.php
index 2e47174..1609b35 100644
--- a/app/Controller/v3/OrderOnlineController.php
+++ b/app/Controller/v3/OrderOnlineController.php
@@ -103,6 +103,7 @@ class OrderOnlineController extends BaseController
             ->orderByDesc('updated_at')
             ->first();
         $market = Market::find($marketId);
+        $distance = 0;
         if(!empty($address->lng) && !empty($address->lat)){
             $distance = $this->locationService->getDistanceByTencent($market->lng,$market->lat,$address->lng,$address->lat);
         }
diff --git a/app/Request/v3/GoodsEditorRequest.php b/app/Request/v3/GoodsEditorRequest.php
new file mode 100644
index 0000000..40cabc4
--- /dev/null
+++ b/app/Request/v3/GoodsEditorRequest.php
@@ -0,0 +1,36 @@
+<?php
+
+declare(strict_types=1);
+
+namespace App\Request\v3;
+
+use App\Request\BaseFormRequest;
+
+class GoodsEditorRequest extends BaseFormRequest
+{
+
+    /**
+     * Get the validation rules that apply to the request.
+     */
+    public function rules(): array
+    {
+        return [
+            'id' => 'required|nonempty|integer',
+        ];
+    }
+
+    /**
+     * @return array
+     */
+    public function messages(): array
+    {
+        return [
+            '*.*' => ':attribute无效',
+        ];
+    }
+
+    public function attributes(): array
+    {
+        return parent::attributes();
+    }
+}
diff --git a/app/Service/v3/Implementations/GoodsService.php b/app/Service/v3/Implementations/GoodsService.php
index 56512fb..90d4445 100644
--- a/app/Service/v3/Implementations/GoodsService.php
+++ b/app/Service/v3/Implementations/GoodsService.php
@@ -78,15 +78,12 @@ class GoodsService implements GoodsServiceInterface
 
     public function update($params)
     {
-        $goods = Goods::query()->withoutGlobalScope('normal')->find($params['id']);
+        $goods = Goods::query()->withoutGlobalScope('normal')->where('id',$params['id'])->first();
         if (empty($goods)) {
             throw new ErrorCodeException( ErrorCode::GOODS_NOT_EXISTS);
         }
-        foreach ($params as $k => $v){
-            if(isset($goods->$k)){
-                $goods->$k = $v;
-            }
-        }
+        $goods->price = $params['price'];
+        $goods->on_sale = $params['on_sale'];
         return $goods->save();
     }