From 1ad034cc2c785017349547215decec25a2770981 Mon Sep 17 00:00:00 2001
From: liangyuyan <1103300295@qq.com>
Date: Wed, 12 Aug 2020 11:33:13 +0800
Subject: [PATCH] =?UTF-8?q?=E4=BC=98=E6=83=A0=E5=88=B8=E8=BF=94=E5=88=B8?=
 =?UTF-8?q?=E6=B4=BB=E5=8A=A8--=E8=AF=B7=E6=B1=82=E5=8F=82=E6=95=B0ids?=
 =?UTF-8?q?=E4=B8=BA=E7=A9=BA=E5=A4=84=E7=90=86?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/Request/CouponRebateReceiveRequest.php |  3 ---
 app/Service/CommonService.php              | 25 ++++++++++++++++++++++
 app/Service/CouponRebateService.php        | 19 +++++++++++++---
 3 files changed, 41 insertions(+), 6 deletions(-)
 create mode 100644 app/Service/CommonService.php

diff --git a/app/Request/CouponRebateReceiveRequest.php b/app/Request/CouponRebateReceiveRequest.php
index 4c4beed..7abce7d 100644
--- a/app/Request/CouponRebateReceiveRequest.php
+++ b/app/Request/CouponRebateReceiveRequest.php
@@ -24,7 +24,6 @@ class CouponRebateReceiveRequest extends FormRequest
         return [
             'user_id' => 'required|nonempty|integer|exists_enable:ims_cjdc_user,id',
             'receive_type' => 'required|nonempty|integer',
-            'ids' => 'required|nonempty',
         ];
     }
 
@@ -33,7 +32,6 @@ class CouponRebateReceiveRequest extends FormRequest
         return [
             'user_id.*' => ':attribute信息不正确',
             'receive_type.*' => ':attribute必须',
-            'ids.*' => ':attribute必须',
         ];
     }
 
@@ -42,7 +40,6 @@ class CouponRebateReceiveRequest extends FormRequest
         return [
             'user_id' => '领取用户ID',
             'receive_type' => '领取方式',
-            'ids' => '优惠券',
         ];
     }
 }
diff --git a/app/Service/CommonService.php b/app/Service/CommonService.php
new file mode 100644
index 0000000..9ffb169
--- /dev/null
+++ b/app/Service/CommonService.php
@@ -0,0 +1,25 @@
+<?php
+
+namespace App\Service;
+
+class CommonService
+{
+
+    /**
+     * 请求参数判空
+     * @param mixed $var 参数
+    */
+    public function empty($var)
+    {
+        return ! (
+            isset($var)
+            && $var
+            && !empty($var)
+            && !is_null($var)
+            && $var != 'undefined'
+            && $var != 'unknown'
+            && $var != 'null'
+            && $var != 'false'
+        );
+    }
+}
\ No newline at end of file
diff --git a/app/Service/CouponRebateService.php b/app/Service/CouponRebateService.php
index c907186..539a404 100644
--- a/app/Service/CouponRebateService.php
+++ b/app/Service/CouponRebateService.php
@@ -13,6 +13,7 @@ use Hyperf\Utils\ApplicationContext;
 use App\TaskWorker\SSDBTask;
 use App\Constants\SsdbKeysPrefix;
 use Exception;
+use App\Service\CommonService;
 
 use function AlibabaCloud\Client\json;
 
@@ -24,6 +25,12 @@ class CouponRebateService implements CouponRebateServiceInterface
      */
     protected $log;
 
+    /**
+     * @Inject
+     * @var CommonService
+     */
+    protected $commonService;
+
     /**
      * 领取优惠券
      * 返券活动领取
@@ -34,16 +41,22 @@ class CouponRebateService implements CouponRebateServiceInterface
     {
         $userId         = $params["user_id"];
         $receiveType    = $params["receive_type"];
-        $ids            = $params["ids"];
         $sendUserId     = $params["send_user_id"];
         $phone          = $params["phone"];
-        $idsData        = is_array($ids) ? $ids : explode(',',$ids);
+        
 
         // status: 0领取成功  >0领取失败
         $result = [
             'status'        => 1,
             'coupon_text'   => '活动已过期~'
         ];
+        /* 如果请求的优惠券ids为空，则返回过期提示 */
+        if($this->commonService->empty($params["ids"])){
+            return $result;
+        }
+
+        $ids     = $params["ids"];
+        $idsData = is_array($ids) ? $ids : explode(',',$ids);
 
         // 错误日志记录
         $errorData = [
@@ -150,7 +163,7 @@ class CouponRebateService implements CouponRebateServiceInterface
             }
 
             if(count($receiveSsdb) > 0){
-;
+
                 $saveSsdb = [
                     $ssdbKey,
                     implode(',',$receiveSsdb)